[FR-52] feat: Session usage monitor in react #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.01% (-0.02% 🔻) |
398/7948 |
| 🔴 | Branches | 4.32% (-0.06% 🔻) |
237/5490 |
| 🔴 | Functions | 3.01% (-0.01% 🔻) |
78/2595 |
| 🔴 | Lines | 4.93% (-0.02% 🔻) |
383/7776 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / SessionUsageMonitor.tsx |
0% | 0% | 0% | 0% |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 0900b2e
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
3a48b36 to
8358664
Compare
agatha197
requested changes
Nov 12, 2024
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
8358664 to
63bd1b2
Compare
agatha197
requested changes
Nov 12, 2024
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
63bd1b2 to
e85e6a4
Compare
yomybaby
requested changes
Nov 19, 2024
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
e85e6a4 to
87e4942
Compare
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
87e4942 to
a1bc1c6
Compare
yomybaby
requested changes
Nov 28, 2024
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
a1bc1c6 to
c15e3d9
Compare
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
c15e3d9 to
ca597df
Compare
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
ca597df to
3ef88fd
Compare
|
The size property of progressProps or showIcon can be used to modify the visibility of the icon or the size of the progress bar. |
ironAiken2
changed the title
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
4 times, most recently
from
5f15ae8 to
22a1850
Compare
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
16426c7 to
f84a448
Compare
Merge activity
|
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR resolves [#2803](#2803) issue. **Changes:** - Displays the resources allocated to the session. Currently, the compute session node does not include a live stat field, which shows the live stat information of the main kernel associated with the session. - Since each device has different usage, I've shown the usage below the progress bar to bring consistency to the design. **How to test:** - Access the Detail page of the endpoint that is currently in service. - Verify that resource usage looks normal. |normal|small screen| |---|---| ||| **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
ironAiken2
force-pushed
the
feat/session-usage-monitor
branch
from
f84a448 to
0900b2e
Compare
|](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/b491c912-330f-4467-b995-b0d05aded2ea.png)||){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2803 issue.
Changes:
How to test:
Checklist: (if applicable)